-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][UI] Flink task display right version and deploy mode #13628
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #13628 +/- ##
============================================
- Coverage 39.06% 39.05% -0.01%
- Complexity 4422 4424 +2
============================================
Files 1127 1127
Lines 42096 42096
Branches 4775 4771 -4
============================================
- Hits 16444 16441 -3
- Misses 23836 23839 +3
Partials 1816 1816
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed!
|
fix use-flink.ts: |
You should create an issue to describe this bug. |
Hi, @chenss-1 , the fix in this pr works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of the pull request
Existed flink task can not display the right flink version and deploy mode because the flink version is hard coded.
Wrong display:
Expected display:
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md