Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][UI] Flink task display right version and deploy mode #13628

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Feb 25, 2023

Purpose of the pull request

Existed flink task can not display the right flink version and deploy mode because the flink version is hard coded.

Wrong display:

image

Expected display:

image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Feb 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #13628 (1e13139) into dev (6516240) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1e13139 differs from pull request most recent head a632a7f. Consider uploading reports for the commit a632a7f to get more accurate results

@@             Coverage Diff              @@
##                dev   #13628      +/-   ##
============================================
- Coverage     39.06%   39.05%   -0.01%     
- Complexity     4422     4424       +2     
============================================
  Files          1127     1127              
  Lines         42096    42096              
  Branches       4775     4771       -4     
============================================
- Hits          16444    16441       -3     
- Misses        23836    23839       +3     
  Partials       1816     1816              
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Feb 27, 2023
@SbloodyS SbloodyS added this to the 3.1.5 milestone Feb 27, 2023
@chenss-1
Copy link

fix use-flink.ts:
watchEffect(() => { if(model.programType === 'SQL'){ model.flinkVersion = '>=1.13' }else { if(model.flinkVersion === '>=1.13'){ model.flinkVersion = '<1.10' } } // model.flinkVersion = model.programType === 'SQL' ? '>=1.13' : '<1.10' })

@devosend
Copy link
Contributor

You should create an issue to describe this bug.

@Radeity
Copy link
Member Author

Radeity commented Feb 28, 2023

Hi, @devosend , the description of UI bug is same as #13644, i've already added more explanation of this bug in the purpose of this pr, for not creating duplicated issue. Thanks for reminding, next time, i'll create an issue first.

@Radeity
Copy link
Member Author

Radeity commented Feb 28, 2023

fix use-flink.ts: watchEffect(() => { if(model.programType === 'SQL'){ model.flinkVersion = '>=1.13' }else { if(model.flinkVersion === '>=1.13'){ model.flinkVersion = '<1.10' } } // model.flinkVersion = model.programType === 'SQL' ? '>=1.13' : '<1.10' })

Hi, @chenss-1 , the fix in this pr works.

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants