Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-11583][UI] Fix the API usage of gantt graph #13778

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

lxorc
Copy link
Contributor

@lxorc lxorc commented Mar 22, 2023

Purpose of the pull request

Fixes #11583, the backend passed wrong data that cannot be parsed by the frontend.

(The import items were changed because of the spotless check)

Verify this pull request

This change added tests and can be verified as follows: Manually verified the change by testing locally.

@lxorc
Copy link
Contributor Author

lxorc commented Mar 22, 2023

Please review the backend @SbloodyS

@lxorc
Copy link
Contributor Author

lxorc commented Mar 22, 2023

@caishunfeng Please review the backend

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added bug Something isn't working 3.0.x 3.1.x for 3.1.x version labels Mar 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #13778 (dfb5836) into dev (69e7449) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head dfb5836 differs from pull request most recent head ab8a8a0. Consider uploading reports for the commit ab8a8a0 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13778      +/-   ##
============================================
- Coverage     39.02%   38.97%   -0.05%     
+ Complexity     4450     4442       -8     
============================================
  Files          1133     1133              
  Lines         42353    42353              
  Branches       4789     4793       +4     
============================================
- Hits          16528    16507      -21     
- Misses        23999    24021      +22     
+ Partials       1826     1825       -1     
Impacted Files Coverage Δ
...r/api/service/impl/ProcessInstanceServiceImpl.java 59.92% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

12.1% 12.1% Coverage
10.9% 10.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] Gantt chart does not show
4 participants