Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-13869: add return success judge #13873

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix-13869: add return success judge #13873

merged 1 commit into from
Apr 19, 2023

Conversation

jackfanwan
Copy link
Contributor

add return success judge

close: #13869

caishunfeng
caishunfeng approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added bug Something isn't working 3.0.x labels Apr 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 6, 2023
SbloodyS
SbloodyS approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

SbloodyS
SbloodyS reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failed CI.

@jackfanwan
Copy link
Contributor Author

Please check the failed CI.

@SbloodyS this is ci problem, please try for me

@caishunfeng caishunfeng merged commit dc4cd97 into apache:dev Apr 19, 2023
zhuangchong pushed a commit that referenced this pull request Apr 30, 2023
@jackfanwan @zhuangchong
add return success judge (#13873)
0418b05 
Co-authored-by: fanwanlong <fanwanlong@kezaihui.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng caishunfeng approved these changes

Assignees

@jackfanwan jackfanwan

Labels
backend bug Something isn't working
Projects
None yet
Milestone
3.1.6
Development

Successfully merging this pull request may close these issues.

[Improvement] [dolphinscheduler-api] There is no judgment whether to return to success
4 participants
@jackfanwan @caishunfeng @SbloodyS @zhuangchong