Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Data Quality] Fixing the incorrect DML statements in the metadata upgrade SQL. #13960

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

yuanoOo
Copy link
Contributor

@yuanoOo yuanoOo commented Apr 19, 2023

fix #13959
Fixing the incorrect DML statements in the metadata upgrade SQL.

Purpose of the pull request

Brief change log

This error is only present in the postgresql version of the DML script.

Verify this pull request

This pull request is code cleanup without any test coverage.

@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.1.6 labels Apr 19, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone Apr 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #13960 (e65b604) into dev (53bcf11) will not change coverage.
The diff coverage is n/a.

❗ Current head e65b604 differs from pull request most recent head 2982ccb. Consider uploading reports for the commit 2982ccb to get more accurate results

@@            Coverage Diff            @@
##                dev   #13960   +/-   ##
=========================================
  Coverage     38.89%   38.89%           
- Complexity     4467     4474    +7     
=========================================
  Files          1164     1164           
  Lines         42444    42444           
  Branches       4761     4757    -4     
=========================================
  Hits          16507    16507           
- Misses        24116    24117    +1     
+ Partials       1821     1820    -1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@zhongjiajie
Copy link
Member

restart the failed CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
5 participants