Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Registry][Jdbc] Add jdbc registry config in helm charts #14431

Merged
merged 24 commits into from
Oct 12, 2023
Merged

[Improvement][Registry][Jdbc] Add jdbc registry config in helm charts #14431

merged 24 commits into from
Oct 12, 2023

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Jun 30, 2023

No description provided.

@rickchengx
Copy link
Contributor

@qingwli please Run 'mvn spotless:apply' to fix these violations.

@qingwli
Copy link
Member Author

qingwli commented Jul 4, 2023

@rickchengx Done

@rickchengx rickchengx added the improvement make more easy to user or prompt friendly label Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #14431 (c618736) into dev (d683553) will not change coverage.
The diff coverage is n/a.

❗ Current head c618736 differs from pull request most recent head 5fb5b21. Consider uploading reports for the commit 5fb5b21 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14431   +/-   ##
=========================================
  Coverage     38.88%   38.88%           
  Complexity     4610     4610           
=========================================
  Files          1236     1236           
  Lines         43449    43449           
  Branches       4809     4809           
=========================================
  Hits          16897    16897           
  Misses        24680    24680           
  Partials       1872     1872

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qingwli
Copy link
Member Author

qingwli commented Jul 4, 2023

PTAL @kezhenxu94

@rickchengx rickchengx added the 3.2.0 for 3.2.0 version label Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@qingwli
Copy link
Member Author

qingwli commented Sep 27, 2023

PTAL @EricGao888 @rickchengx @Gallardot

Gallardot
Gallardot approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli qingwli removed the 3.2.0 for 3.2.0 version label Sep 28, 2023
@qingwli
Copy link
Member Author

qingwli commented Sep 28, 2023

@Gallardot PLTA Again

@qingwli
Copy link
Member Author

qingwli commented Oct 11, 2023

PTAL @Radeity @SbloodyS

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Radeity
Radeity approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli qingwli modified the milestones: 3.3.0, 3.2.1 Oct 12, 2023
@qingwli qingwli added the 3.2.1 label Oct 12, 2023
@qingwli qingwli merged commit b532fe5 into apache:dev Oct 12, 2023
53 checks passed
@qingwli qingwli deleted the registry-support-jdbc branch October 12, 2023 01:52
@qingwli qingwli mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@Gallardot Gallardot Gallardot approved these changes

@Radeity Radeity Radeity approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@qingwli qingwli

Labels
3.2.1 document improvement make more easy to user or prompt friendly kubernetes ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@qingwli @rickchengx @codecov-commenter @Gallardot @kezhenxu94 @Radeity @davidzollo @EricGao888