Set kubectl version to v1.28.3 #15053
Conversation
|
@Gallardot do you have time to take a look this PR? |
Codecov Report
@@ Coverage Diff @@
## dev #15053 +/- ##
============================================
- Coverage 38.95% 38.94% -0.01%
+ Complexity 4599 4598 -1
============================================
Files 1231 1231
Lines 43354 43354
Branches 4795 4795
============================================
- Hits 16887 16886 -1
Misses 24594 24594
- Partials 1873 1874 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -70,7 +70,7 @@ jobs: | |||
| - name: Create k8s Kind Cluster | |||
| run: | | |||
| # install kubectl | |||
| curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl" | |||
There was a problem hiding this comment.
It's odd that CI can not get the value from this link, because I can get v1.28.3 with command echo $(curl -L -s https://dl.k8s.io/release/stable.txt)
There was a problem hiding this comment.
I think the reason @Gallardot wants to check the latest stable version, so it use value from this link
There was a problem hiding this comment.
I understand the purpose of this PR. It is indeed necessary to use a specific version of kubectl instead of using the latest version of kubectl because the iteration of k8s version is relatively frequent. Perhaps we should unify the versions of kubectl and the kind cluster to avoid version differences.
There was a problem hiding this comment.
Yes, and this change is due to current our ci has blocked, this might due to we get the incompatibility version.
|
Kudos, SonarCloud Quality Gate passed! |
ruanwenjun
added
ready-to-merge
improvement
Purpose of the pull request
The ci has been blocked, this might due to we get the incorrect kubectl version.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md