Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IT for initialize application and upgrade application under mysql5/postgre16 environment #15063

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Oct 23, 2023

Purpose of the pull request

Brief change log

  • Add DolphinSchedulerDatabaseContainer and DolphinSchedulerDatabaseContainerExtension used to help create container test case.
  • Add Mysql5.7/Postgre16 test case.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Oct 23, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addPGV16IT branch 2 times, most recently from 5d0a281 to 91dcbf8 Compare October 24, 2023 03:58
caishunfeng
caishunfeng previously approved these changes Oct 24, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@caishunfeng
Copy link
Contributor

It's better to update a correct title and add some pr details.

@ruanwenjun ruanwenjun changed the title Add IT for mysql5/postgresql16 initialize/upgrade Add IT for initialize application and upgrade application under mysql5/postgre16 environment Oct 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #15063 (ac11874) into dev (c59b2d5) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ac11874 differs from pull request most recent head 34a58e8. Consider uploading reports for the commit 34a58e8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15063      +/-   ##
============================================
+ Coverage     39.00%   39.01%   +0.01%     
  Complexity     4599     4599              
============================================
  Files          1231     1231              
  Lines         43300    43300              
  Branches       4792     4792              
============================================
+ Hits          16888    16895       +7     
+ Misses        24536    24527       -9     
- Partials       1876     1878       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit 2350775 into apache:dev Oct 24, 2023
53 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addPGV16IT branch October 24, 2023 06:44
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants