[Bug] Expire session when update user password

[ruanwenjun]

Purpose of the pull request

When we delete or update the user's password, the old session will expire.

Brief change log

• One user will bind to one session even if you use multiple ip.
• When the user changed, will expire the exist session.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[codecov-commenter]

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (0016b96) 38.00% compared to head (6894ede) 37.99%.

❗ Current head 6894ede differs from pull request most recent head 72c8885. Consider uploading reports for the commit 72c8885 to get more accurate results

Files	Patch %	Lines
...inscheduler/api/service/impl/UsersServiceImpl.java	27.77%	10 Missing and 3 partials ⚠️
...pache/dolphinscheduler/dao/repository/BaseDao.java	0.00%	6 Missing ⚠️
...lphinscheduler/api/controller/UsersController.java	0.00%	4 Missing ⚠️
...scheduler/api/service/impl/SessionServiceImpl.java	77.77%	2 Missing and 2 partials ⚠️
...nscheduler/dao/repository/impl/SessionDaoImpl.java	33.33%	3 Missing and 1 partial ⚠️
...duler/api/security/impl/AbstractAuthenticator.java	72.72%	1 Missing and 2 partials ⚠️
...uler/api/security/impl/ldap/LdapAuthenticator.java	0.00%	0 Missing and 1 partial ⚠️
...er/api/security/impl/sso/CasdoorAuthenticator.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15219      +/-   ##
============================================
- Coverage     38.00%   37.99%   -0.02%     
+ Complexity     4644     4640       -4     
============================================
  Files          1279     1279              
  Lines         44539    44490      -49     
  Branches       4800     4794       -6     
============================================
- Hits          16927    16902      -25     
+ Misses        25759    25733      -26     
- Partials       1853     1855       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[caishunfeng]

👍

[caishunfeng]

Can we avoid to use wrapper? Although this is a simple query looks fine, many complex query wrapper may be written later.
Use mapper.xml uniformly is a better way, WDYT?

[ruanwenjun]

Agree with you, we shouldn't expose wrapper to service. I change this method to

/**
 * Query the entity by condition.
 */
List<Entity> queryByCondition(Entity queryCondition);

And add implementation in BaseDao

@Override
public List<ENTITY> queryByCondition(ENTITY queryCondition) {
    if (queryCondition == null) {
        throw new IllegalArgumentException("queryCondition can not be null");
    }
    return mybatisMapper.selectList(new QueryWrapper<>(queryCondition));
}

Then we can avoid using wrapper in dao, then we can use this method for simple query, and remove a lot of method like queryByCode, queryByName, queryByXX, for this kind of query we can directly use dao.queryByCondition(entity).

[caishunfeng]

It seems good.

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[caishunfeng]

LGTM