-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dolphinscheduler-extract-common module #15266
Add dolphinscheduler-extract-common module #15266
Conversation
c3dcfdf
to
e473afb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15266 +/- ##
============================================
+ Coverage 38.06% 38.09% +0.03%
+ Complexity 4663 4658 -5
============================================
Files 1280 1280
Lines 44583 44519 -64
Branches 4803 4794 -9
============================================
- Hits 16970 16961 -9
+ Misses 25744 25693 -51
+ Partials 1869 1865 -4 ☔ View full report in Codecov by Sentry. |
@ruanwenjun Can you add the doc to desc the module relations? |
e473afb
to
0ca6a19
Compare
Added README.md, PTAL |
0ca6a19
to
d25b549
Compare
2d8b191
to
36b615d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarCloud Quality Gate failed.
|
Purpose of the pull request
Move the common interface into
dolphinscheduler-extract-common
.Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md