Add dolphinscheduler-extract-common module #15266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_removeLogServiceInCommonModule
branch
from
c3dcfdf
to
e473afb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15266 +/- ##
============================================
+ Coverage 38.06% 38.09% +0.03%
+ Complexity 4663 4658 -5
============================================
Files 1280 1280
Lines 44583 44519 -64
Branches 4803 4794 -9
============================================
- Hits 16970 16961 -9
+ Misses 25744 25693 -51
+ Partials 1869 1865 -4 ☔ View full report in Codecov by Sentry. |
|
@ruanwenjun Can you add the doc to desc the module relations? |
ruanwenjun
force-pushed
the
dev_wenjun_removeLogServiceInCommonModule
branch
from
e473afb
to
0ca6a19
Compare
Added README.md, PTAL |
ruanwenjun
force-pushed
the
dev_wenjun_removeLogServiceInCommonModule
branch
from
0ca6a19
to
d25b549
Compare
ruanwenjun
force-pushed
the
dev_wenjun_removeLogServiceInCommonModule
branch
from
2d8b191
to
36b615d
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Move the common interface into
dolphinscheduler-extract-common.Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md