-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #15129] [Dependent] The date rules of the dependent node are ambiguous. #15289
Conversation
|
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.1_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
We can add this change to the document in the version 3.2.1 to inform the user of this change. @reele |
Sure! |
You can add it to |
docs updated. @SbloodyS |
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run mvn spotless:apply
to format code. @reele
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15289 +/- ##
============================================
- Coverage 38.19% 38.19% -0.01%
Complexity 4673 4673
============================================
Files 1278 1278
Lines 44481 44482 +1
Branches 4783 4783
============================================
Hits 16988 16988
- Misses 25631 25632 +1
Partials 1862 1862 ☔ View full report in Codecov by Sentry. |
SonarCloud Quality Gate failed.
|
Purpose of the pull request
This pull request fix #15129
Brief change log
Restore the date matching logic for dependent task in scheduling:
search for
processInstance
through thescheduleTime
in schedule command. Through theprocessInstance
, search fortaskInstance
. The 'endTime' of thetaskInstance
is only used to sort and find the maximum value.Add corresponding indexes for the new SQL definition.Note: This may cause historical cost logic conflicts with existing users in
dev
branch.@SbloodyS
Verify this pull request
This pull request is already covered by existing tests.