Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Optimize server startup log #15362

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Dec 25, 2023

Purpose of the pull request

  • Optimize the server startup log, e.g config format, Rpc server, log patten of class.
  • Remove unused code.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly backend labels Dec 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (5523a62) 38.10% compared to head (dd2c122) 38.11%.

❗ Current head dd2c122 differs from pull request most recent head bac32c6. Consider uploading reports for the commit bac32c6 to get more accurate results

Files Patch % Lines
...hinscheduler/extract/base/NettyRemotingServer.java 42.85% 8 Missing ⚠️
...inscheduler/server/worker/config/WorkerConfig.java 0.00% 4 Missing ⚠️
...apache/dolphinscheduler/common/utils/NetUtils.java 50.00% 2 Missing and 1 partial ⚠️
...che/dolphinscheduler/alert/rpc/AlertRpcServer.java 0.00% 2 Missing ⚠️
...inscheduler/server/master/config/MasterConfig.java 0.00% 2 Missing ⚠️
...inscheduler/server/master/rpc/MasterRpcServer.java 0.00% 2 Missing ⚠️
.../server/master/runner/StateWheelExecuteThread.java 0.00% 2 Missing ⚠️
...inscheduler/server/worker/rpc/WorkerRpcServer.java 0.00% 2 Missing ⚠️
...ache/dolphinscheduler/dao/entity/TaskInstance.java 0.00% 1 Missing ⚠️
...er/master/builder/TaskExecutionContextBuilder.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15362      +/-   ##
============================================
+ Coverage     38.10%   38.11%   +0.01%     
  Complexity     4697     4697              
============================================
  Files          1301     1300       -1     
  Lines         44800    44775      -25     
  Branches       4800     4800              
============================================
- Hits          17070    17065       -5     
+ Misses        25877    25858      -19     
+ Partials       1853     1852       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caishunfeng caishunfeng changed the title Optimize server startup log [Improvement] Optimize server startup log Dec 27, 2023
@caishunfeng
Copy link
Contributor

Please add some pr description.

@ruanwenjun
Copy link
Member Author

Please add some pr description.

Done

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

18.6% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit d6dea46 into apache:dev Dec 27, 2023
51 of 52 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_optimizeLogDev branch January 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants