Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][API]Enhance mysql connection properties #15433

Merged
merged 4 commits into from Jan 6, 2024

Conversation

lgcareer
Copy link
Contributor

@lgcareer lgcareer commented Jan 5, 2024

Purpose of the pull request

This pull request enhance mysql connection properties

Brief change log

  • Enhance mysql connection properties

@lgcareer lgcareer added this to the 3.2.1 milestone Jan 5, 2024
@lgcareer lgcareer added 3.2.1 and removed backend labels Jan 5, 2024
@zhongjiajie
Copy link
Member

tests error, could you please fix it?

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6c1e001) 38.11% compared to head (23382e6) 38.11%.

❗ Current head 23382e6 differs from pull request most recent head 637454f. Consider uploading reports for the commit 637454f to get more accurate results

Files Patch % Lines
...tasource/mysql/param/MySQLDataSourceProcessor.java 5.26% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15433      +/-   ##
============================================
- Coverage     38.11%   38.11%   -0.01%     
- Complexity     4696     4697       +1     
============================================
  Files          1299     1299              
  Lines         44773    44774       +1     
  Branches       4798     4797       -1     
============================================
  Hits          17066    17066              
- Misses        25858    25861       +3     
+ Partials       1849     1847       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgcareer
Copy link
Contributor Author

lgcareer commented Jan 5, 2024

tests error, could you please fix it?

Yes,has fixed.

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@HarshitNagpal29
Copy link

LGTM, thanks

@zhongjiajie sir, sorry to disturb you but i am waiting for your approval and response in HTTP task parameter issue also I have tried to contact you via email.

Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@zhongjiajie zhongjiajie merged commit 309c8c9 into apache:dev Jan 6, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants