Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Fix PostgresqlDatabaseContainerProvider get Image is incorrect #15434

Merged

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dc373d) 38.01% compared to head (3ee2d70) 38.01%.

❗ Current head 3ee2d70 differs from pull request most recent head f808d99. Consider uploading reports for the commit f808d99 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15434      +/-   ##
============================================
- Coverage     38.01%   38.01%   -0.01%     
+ Complexity     4692     4691       -1     
============================================
  Files          1304     1304              
  Lines         44812    44812              
  Branches       4803     4803              
============================================
- Hits          17037    17036       -1     
  Misses        25924    25924              
- Partials       1851     1852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun added CI&CD test bug Something isn't working and removed CI&CD labels Jan 5, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGCOntainerProviderImage branch from f08598c to d9003eb Compare January 6, 2024 10:55
@github-actions github-actions bot removed the test label Jan 6, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGCOntainerProviderImage branch from d9003eb to d939cdc Compare January 8, 2024 02:11
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGCOntainerProviderImage branch from d939cdc to add4903 Compare January 17, 2024 01:56
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI pass

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGCOntainerProviderImage branch from b67216f to febfa45 Compare January 18, 2024 09:31
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGCOntainerProviderImage branch from febfa45 to f808d99 Compare January 18, 2024 14:14
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fuchanghai fuchanghai merged commit dcf69ca into apache:dev Jan 19, 2024
56 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixPGCOntainerProviderImage branch January 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants