-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DefaultUncaughtExceptionHandler to log the uncached exception #15496
Use DefaultUncaughtExceptionHandler to log the uncached exception #15496
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15496 +/- ##
============================================
- Coverage 38.03% 38.02% -0.02%
- Complexity 4688 4692 +4
============================================
Files 1304 1304
Lines 44791 44811 +20
Branches 4803 4803
============================================
+ Hits 17035 17038 +3
- Misses 25904 25922 +18
+ Partials 1852 1851 -1 ☔ View full report in Codecov by Sentry. |
0a90348
to
8982c55
Compare
@@ -127,4 +127,10 @@ public void registerWorkerMemoryUsageGauge(Supplier<Number> supplier) { | |||
.register(Metrics.globalRegistry); | |||
} | |||
|
|||
public static void registerUncachedException(final Supplier<Number> supplier) { | |||
Gauge.builder("ds.master.uncached.exception", supplier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should change to ds.worker.uncached.exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
5e2237b
to
b513008
Compare
b513008
to
509ea1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Purpose of the pull request
SetDefaultUncaughtExceptionHandler in thread.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md