Use DefaultUncaughtExceptionHandler to log the uncached exception #15496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15496 +/- ##
============================================
- Coverage 38.03% 38.02% -0.02%
- Complexity 4688 4692 +4
============================================
Files 1304 1304
Lines 44791 44811 +20
Branches 4803 4803
============================================
+ Hits 17035 17038 +3
- Misses 25904 25922 +18
+ Partials 1852 1851 -1 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_addUncacheExceptionHandler
branch
from
0a90348
to
8982c55
Compare
fuchanghai
reviewed
Jan 17, 2024
| @@ -127,4 +127,10 @@ public void registerWorkerMemoryUsageGauge(Supplier<Number> supplier) { | |||
| .register(Metrics.globalRegistry); | |||
| } | |||
|
|
|||
| public static void registerUncachedException(final Supplier<Number> supplier) { | |||
| Gauge.builder("ds.master.uncached.exception", supplier) | |||
There was a problem hiding this comment.
we should change to ds.worker.uncached.exception
ruanwenjun
force-pushed
the
dev_wenjun_addUncacheExceptionHandler
branch
from
5e2237b
to
b513008
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addUncacheExceptionHandler
branch
from
b513008
to
509ea1a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
SetDefaultUncaughtExceptionHandler in thread.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md