[Fix] [Bug] [Upgrade] Resolved no data on the task instance page after upgrading from 1.3.x to 3.1.x #15498
Conversation
pinkfloyds
changed the title
| @@ -415,7 +415,7 @@ alter table t_ds_process_instance drop dependence_schedule_times; | |||
|
|
|||
| -- t_ds_task_instance note: Data migration is not supported | |||
| alter table t_ds_task_instance change process_definition_id task_code bigint(20) NOT NULL COMMENT 'task definition code'; | |||
| alter table t_ds_task_instance add task_definition_version int(11) DEFAULT '0' COMMENT 'task definition version' AFTER task_code; | |||
| alter table t_ds_task_instance add task_definition_version int(11) DEFAULT '1' COMMENT 'task definition version' AFTER task_code; | |||
There was a problem hiding this comment.
The default value of t_ds_task_instance is '0', we cannot change this.
There was a problem hiding this comment.
Or I could add it here ？
update t_ds_task_instance set task_definition_version ='1';
There was a problem hiding this comment.
LGTM only update the task_definition_version, but the version in t_ds_task_definition, t_ds_task_definition_log should start from 0, after you upgrade there should only contains one version in these two table, this is strange.
There was a problem hiding this comment.
t_ds_task_inset.task_definition_version is assigned to 1 for the first time, which is not useful when the default value is 0,the data in the table should not have t_ds_task_instance task_definition_version = 0,so update t_ds_task_instance set task_definition_version ='1'
There was a problem hiding this comment.
Oh, I see the code will set the begin version to 0. So set the default version to 1 is the correct way.
Could you please change the default value in the initialize sql.
https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-dao/src/main/resources/sql
And we also need to alter this latest version https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-dao/src/main/resources/sql/upgrade/3.2.1_schema.
ruanwenjun
force-pushed
the
dev_2024_1_16
branch
from
26e399b
to
80ca04c
Compare
| alter table t_ds_process_definition alter column `version` set default 1; | ||
| alter table t_ds_process_definition alter column `version` int(11) NOT NULL; |
There was a problem hiding this comment.
alter table t_ds_process_definition modify column `version` int(11) NOT NULL default 1;
There was a problem hiding this comment.
ok,have been modified
|
|
Prompt to add the ready-to-merge label. Can you add it? I can't find an action to add a label |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15498 +/- ##
=========================================
Coverage 38.10% 38.10%
Complexity 4698 4698
=========================================
Files 1304 1304
Lines 44818 44818
Branches 4804 4804
=========================================
Hits 17080 17080
Misses 25884 25884
Partials 1854 1854 ☔ View full report in Codecov by Sentry. |
|
ruanwenjun
force-pushed
the
dev_2024_1_16
branch
from
d00f5af
to
1e76304
Compare
…n t_ds_task_definition_log.version lead to task Instance list tab be empty
ruanwenjun
force-pushed
the
dev_2024_1_16
branch
from
5134afb
to
91bd976
Compare
|
no data on the task instance page after upgrading from 1.3.4 to 3.1.x
modify the update script to change t_ds_task_instance.task_definition_version default to 1 .
see #15497