Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][HTTP] support customization of the JSON format in http body #15531

Merged
merged 3 commits into from Jan 31, 2024

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

image

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@github-actions github-actions bot added UI ui and front end related backend labels Jan 29, 2024
@Gallardot Gallardot changed the title [Improvement][HTTP] support custom rendering of http body [Improvement][HTTP] support customization of the JSON format in http body Jan 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (86ef966) 38.15% compared to head (2fa2302) 38.15%.

❗ Current head 2fa2302 differs from pull request most recent head 01feaa8. Consider uploading reports for the commit 01feaa8 to get more accurate results

Files Patch % Lines
...he/dolphinscheduler/plugin/task/http/HttpTask.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15531   +/-   ##
=========================================
  Coverage     38.15%   38.15%           
- Complexity     4705     4708    +3     
=========================================
  Files          1304     1304           
  Lines         44820    44828    +8     
  Branches       4805     4807    +2     
=========================================
+ Hits          17099    17106    +7     
  Misses        25870    25870           
- Partials       1851     1852    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.3.0 labels Jan 30, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jan 30, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's great! Thanks.

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fuchanghai fuchanghai merged commit 3640a28 into apache:dev Jan 31, 2024
58 checks passed
@Gallardot Gallardot deleted the http-body branch January 31, 2024 03:15
Gallardot added a commit to Gallardot/dolphinscheduler that referenced this pull request Mar 14, 2024
Signed-off-by: Gallardot <gallardot@apache.org>
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Gallardot pushed a commit to Gallardot/dolphinscheduler that referenced this pull request Mar 14, 2024
[Improvement][HTTP] support custom rendering of http body (apache#15531)

See merge request logan/devops/apache/dolphinscheduler!19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][HTTP] support customization of the JSON format in http body
6 participants