[Worker] Fix will not kill the subprocess in remote when stop a remote-shell task #15570 #15629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alei1206
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15629 +/- ##
============================================
- Coverage 39.24% 39.17% -0.08%
+ Complexity 4910 4893 -17
============================================
Files 1323 1323
Lines 45184 45187 +3
Branches 4810 4810
============================================
- Hits 17734 17703 -31
- Misses 25572 25603 +31
- Partials 1878 1881 +3 ☔ View full report in Codecov by Sentry. |
ruanwenjun
reviewed
Mar 1, 2024
...eshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java
Outdated
Show resolved
Hide resolved
ruanwenjun
changed the title
rickchengx
reviewed
Mar 15, 2024
...r-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/ProcessUtils.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix cannot kill the subprocess when stop a remote-shell task #15570
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md