[Improvement-15603][API] When removing or modifying a workflow the system can check if there any tasks depend on it. #15681

calvinjiang · 2024-03-07T07:39:07Z

Purpose of the pull request

This PR will close #15603 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

Manually verified the change by testing locally.

The test results are as follows:

...-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkFlowLineageController.java

+    })
+    @GetMapping(value = "/query-dependent-tasks")
+    @ResponseStatus(HttpStatus.OK)
+    public Result<Map<String, Object>> queryDownstreamDependentTaskList(@Parameter(hidden = true) @RequestAttribute(value = SESSION_USER) User loginUser,


...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/WorkFlowLineageService.java

...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java

codecov-commenter · 2024-03-07T09:48:47Z

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 38.96%. Comparing base (e3fdb1a) to head (e7831dd).

❗ Current head e7831dd differs from pull request most recent head 5a7c99c. Consider uploading reports for the commit 5a7c99c to get more accurate results

Files	Patch %	Lines
...r/api/service/impl/WorkFlowLineageServiceImpl.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15681      +/-   ##
============================================
- Coverage     38.96%   38.96%   -0.01%     
- Complexity     4838     4840       +2     
============================================
  Files          1316     1316              
  Lines         45000    45010      +10     
  Branches       4817     4818       +1     
============================================
+ Hits          17535    17538       +3     
- Misses        25568    25576       +8     
+ Partials       1897     1896       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhuangchong · 2024-03-07T11:28:32Z

...-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkFlowLineageController.java

+        } catch (Exception e) {
+            log.error(QUERY_WORKFLOW_LINEAGE_ERROR.getMsg(), e);
+            return error(QUERY_WORKFLOW_LINEAGE_ERROR.getCode(), QUERY_WORKFLOW_LINEAGE_ERROR.getMsg());
+        }


I recommend using @ApiException annotation for this part of the code.

zhuangchong · 2024-03-07T11:30:45Z

...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java

+    /**
+     * Check if there're any tasks that depend on the process
+     */
+    private void checkIfDependentTaskExists(ProcessDefinition processDefinition) {


zhuangchong · 2024-03-07T11:33:44Z

dolphinscheduler-ui/src/views/projects/workflow/components/dag/dag-context-menu.tsx

+    // const dependenciesData = reactive({
+    //       showRef: false,
+    //       taskLinks: ref([]),
+    //       required: ref(false),
+    //       tip: ref(''), action: () => {}
+    // })


Please delete this part.

songjianet

Please delete introduced but unused variables

zhuangchong

+1

songjianet

…inscheduler into f-validate-dependences

sonarcloud · 2024-03-09T16:20:58Z

Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

qingwli · 2024-03-11T09:42:30Z

Looks like check https://github.com/apache/dolphinscheduler/actions/runs/8215624741/job/22469292085 not pass @calvinjiang @songjianet

SbloodyS · 2024-03-11T13:40:21Z

Looks like check https://github.com/apache/dolphinscheduler/actions/runs/8215624741/job/22469292085 not pass @calvinjiang @songjianet

It's odd that dolphinscheduler-api module build passed...

SbloodyS · 2024-03-11T13:44:20Z

Maybe the command npm install pnpm@7 -g install an incompatible version of pnpm in

dolphinscheduler/.github/workflows/frontend.yml

Lines 60 to 64 in 2395ba5

    
                   run: | 
        
                     npm install pnpm@7 -g 
        
                     pnpm install 
        
                     pnpm run lint 
        
                     pnpm run build:prod

PTAL @songjianet

qingwli · 2024-03-12T02:17:46Z

Looks like some code format issue

calvinjiang added 10 commits February 20, 2024 20:03

modify the function of queryTaskSubProcessDepOnProcess

21d0840

add a function to query downstream dependent tasks

9d130d6

confirm to make the workflow offline

983ee28

query dependent tasks

f912652

check dependencies

1e718f3

done

b080681

done

2dd06e1

done

399df33

done

b8fa4d1

done

93fee9d

calvinjiang requested review from songjianet, Amy0104, caishunfeng and SbloodyS as code owners March 7, 2024 07:39

github-actions bot added UI ui and front end related backend labels Mar 7, 2024

calvinjiang added this to the 3.2.2 milestone Mar 7, 2024

calvinjiang added improvement make more easy to user or prompt friendly 3.2.2 ready-to-merge labels Mar 7, 2024

github-advanced-security bot found potential problems Mar 7, 2024

View reviewed changes

calvinjiang added 2 commits March 7, 2024 17:24

improve the test case

f67f8f6

improve the test case

5091109

calvinjiang requested a review from zhuangchong March 7, 2024 11:19

zhuangchong reviewed Mar 7, 2024

View reviewed changes

songjianet requested changes Mar 8, 2024

View reviewed changes

calvinjiang added 3 commits March 8, 2024 16:44

improve codes

450e38e

fix conflicts

3045138

Merge branch 'dev' into f-validate-dependences

924f994

zhuangchong previously approved these changes Mar 8, 2024

View reviewed changes

songjianet requested changes Mar 9, 2024

View reviewed changes

calvinjiang requested a review from songjianet March 9, 2024 14:00

calvinjiang added 3 commits March 9, 2024 22:27

prettier the codes

8af5634

Merge branch 'dev' into f-validate-dependences

80394dc

Merge branch 'f-validate-dependences' of github.com:calvinjiang/dolph…

33b7d2f

…inscheduler into f-validate-dependences

calvinjiang dismissed zhuangchong’s stale review via 33b7d2f March 9, 2024 14:29

prettier the codes

5a7c99c

songjianet approved these changes Mar 10, 2024

View reviewed changes

songjianet merged commit c61b81e into apache:dev Mar 10, 2024
55 of 58 checks passed

This was referenced Mar 18, 2024

[CI] Fix ui build error #15732

Merged

[CI] Frontend ci require passed before merge #15735

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Improvement-15603][API] When removing or modifying a workflow the system can check if there any tasks depend on it. #15681

[Improvement-15603][API] When removing or modifying a workflow the system can check if there any tasks depend on it. #15681

calvinjiang commented Mar 7, 2024

codecov-commenter commented Mar 7, 2024 •

edited

zhuangchong Mar 7, 2024

zhuangchong Mar 7, 2024

zhuangchong Mar 7, 2024

songjianet left a comment

zhuangchong left a comment

songjianet left a comment

sonarcloud bot commented Mar 9, 2024

qingwli commented Mar 11, 2024

SbloodyS commented Mar 11, 2024

SbloodyS commented Mar 11, 2024

qingwli commented Mar 12, 2024

[Improvement-15603][API] When removing or modifying a workflow the system can check if there any tasks depend on it. #15681

[Improvement-15603][API] When removing or modifying a workflow the system can check if there any tasks depend on it. #15681

Conversation

calvinjiang commented Mar 7, 2024

Purpose of the pull request

Brief change log

Verify this pull request

codecov-commenter commented Mar 7, 2024 • edited

Codecov Report

zhuangchong Mar 7, 2024

Choose a reason for hiding this comment

zhuangchong Mar 7, 2024

Choose a reason for hiding this comment

zhuangchong Mar 7, 2024

Choose a reason for hiding this comment

songjianet left a comment

Choose a reason for hiding this comment

zhuangchong left a comment

Choose a reason for hiding this comment

songjianet left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 9, 2024

Quality Gate failed

qingwli commented Mar 11, 2024

SbloodyS commented Mar 11, 2024

SbloodyS commented Mar 11, 2024

qingwli commented Mar 12, 2024

codecov-commenter commented Mar 7, 2024 •

edited