[Improvement-15692][task-datasync] rewrite the mockito test file for DatasyncTaskTest. #15693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Dotes
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
Tianqi-Dotes
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15693 +/- ##
============================================
+ Coverage 38.96% 39.04% +0.08%
- Complexity 4840 4844 +4
============================================
Files 1316 1316
Lines 45010 45010
Branches 4818 4818
============================================
+ Hits 17539 17576 +37
+ Misses 25575 25527 -48
- Partials 1896 1907 +11 ☔ View full report in Codecov by Sentry. |
|
|
Hi @Tianqi-Dotes can you add some description for why need to rewrite this UT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Due to the previous test code having defects and misusing the mockito, rewrite the mockito test file for the task-datasync.
Brief change log
Rewrite the mockito test file for the task-datasync.
Verify this pull request
I have tested locally.