Directly use Quartz replase api to bootstrap a schedule #15781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_directlyUseQuartzReplaceAPI
branch
3 times, most recently
from
1f6f6b1
to
681aec2
Compare
|
It's ok to remove lock when build job details and schedule? |
ruanwenjun
force-pushed
the
dev_wenjun_directlyUseQuartzReplaceAPI
branch
from
1437979
to
e43c7dc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rtz/src/main/java/org/apache/dolphinscheduler/scheduler/quartz/QuartzCornTriggerBuilder.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_directlyUseQuartzReplaceAPI
branch
from
e43c7dc
to
bcfd0da
Compare
We don't need to use lock here, and quartz will use db lock when dealing with job/trigger. |
ruanwenjun
force-pushed
the
dev_wenjun_directlyUseQuartzReplaceAPI
branch
5 times, most recently
from
e9e8d49
to
713add8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15781 +/- ##
============================================
- Coverage 39.19% 39.11% -0.08%
- Complexity 4876 4888 +12
============================================
Files 1317 1326 +9
Lines 45039 45206 +167
Branches 4808 4818 +10
============================================
+ Hits 17652 17684 +32
- Misses 25501 25635 +134
- Partials 1886 1887 +1 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_directlyUseQuartzReplaceAPI
branch
from
713add8
to
5c0a1a8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Optimize the scheduler code in quartz plugin, use quartz replace API to insert/update trigger and job.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md