Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add resource full name check #15786

Merged

Conversation

caishunfeng
Copy link
Contributor

Purpose of the pull request

add resource full name check to avoid ../.

Brief change log

ResourceServiceImpl.checkFullName and UT

Verify this pull request

  • Update ResourceServiceTest to verify the change.

@caishunfeng caishunfeng self-assigned this Apr 1, 2024
@caishunfeng caishunfeng added improvement make more easy to user or prompt friendly and removed backend labels Apr 1, 2024
@caishunfeng caishunfeng force-pushed the improvement/resource_full_name_check branch from 1465bdf to a987c0b Compare April 1, 2024 03:56
@caishunfeng
Copy link
Contributor Author

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 39.19%. Comparing base (ac0189a) to head (3ef411a).

❗ Current head 3ef411a differs from pull request most recent head 347d7d5. Consider uploading reports for the commit 347d7d5 to get more accurate results

Files Patch % Lines
...heduler/api/service/impl/ResourcesServiceImpl.java 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15786      +/-   ##
============================================
- Coverage     39.19%   39.19%   -0.01%     
  Complexity     4876     4876              
============================================
  Files          1317     1317              
  Lines         45026    45037      +11     
  Branches       4806     4808       +2     
============================================
+ Hits          17646    17650       +4     
- Misses        25495    25501       +6     
- Partials       1885     1886       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SbloodyS
SbloodyS previously approved these changes Apr 1, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added this to the 3.2.2 milestone Apr 1, 2024
@github-actions github-actions bot removed the e2e e2e test label Apr 1, 2024
Copy link

sonarcloud bot commented Apr 1, 2024

@caishunfeng caishunfeng merged commit 8acc697 into apache:dev Apr 1, 2024
60 checks passed
@caishunfeng caishunfeng deleted the improvement/resource_full_name_check branch April 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants