Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dolphinscheduler-data-quality from dolphinscheduler-task-dataquality #15791

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 2, 2024

Purpose of the pull request

  • Avoid import the extra jar into worker, this kind of jar should only be used at dataquality.

Brief change log

  • Remove dolphinscheduler-data-quality from dolphinscheduler-task-dataquality

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@caishunfeng caishunfeng added the improvement make more easy to user or prompt friendly label Apr 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 34.23423% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 39.08%. Comparing base (920ac15) to head (b201d33).
Report is 1 commits behind head on dev.

❗ Current head b201d33 differs from pull request most recent head 1d035b9. Consider uploading reports for the commit 1d035b9 to get more accurate results

Files Patch % Lines
...ler/scheduler/quartz/QuartzCornTriggerBuilder.java 0.00% 26 Missing ⚠️
...hinscheduler/scheduler/quartz/QuartzScheduler.java 0.00% 19 Missing ⚠️
...duler/scheduler/quartz/QuartzJobDetailBuilder.java 0.00% 15 Missing ⚠️
...cheduler/scheduler/quartz/ProcessScheduleTask.java 0.00% 4 Missing ⚠️
...lphinscheduler/scheduler/quartz/QuartzJobData.java 75.00% 2 Missing and 2 partials ⚠️
...cheduler/plugin/task/dq/utils/RuleParserUtils.java 57.14% 3 Missing ⚠️
...ler/data/quality/flow/batch/reader/JdbcReader.java 50.00% 1 Missing ⚠️
...scheduler/quartz/QuartzSchedulerConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15791      +/-   ##
============================================
- Coverage     39.19%   39.08%   -0.12%     
- Complexity     4876     4883       +7     
============================================
  Files          1317     1326       +9     
  Lines         45039    45176     +137     
  Branches       4808     4796      -12     
============================================
+ Hits          17652    17655       +3     
- Misses        25501    25632     +131     
- Partials       1886     1889       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.2.2 label Apr 2, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Apr 2, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeDQFromWorker branch from f5a6178 to e5641ee Compare April 4, 2024 15:08
Copy link

sonarcloud bot commented Apr 4, 2024

@ruanwenjun ruanwenjun merged commit 3b1de41 into apache:dev Apr 4, 2024
60 of 61 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeDQFromWorker branch April 4, 2024 15:44
abzymeinsjtu pushed a commit to abzymeinsjtu/dolphinscheduler that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants