Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused caffeine cache #15830

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Since we have already removed cache, we need to remove this kind of config. And caffeine is also not needed.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes Apr 11, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.17%. Comparing base (2b5f843) to head (9674b78).

❗ Current head 9674b78 differs from pull request most recent head dfa7bee. Consider uploading reports for the commit dfa7bee to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15830   +/-   ##
=========================================
  Coverage     39.17%   39.17%           
  Complexity     4889     4889           
=========================================
  Files          1323     1323           
  Lines         45187    45187           
  Branches       4811     4811           
=========================================
  Hits          17703    17703           
  Misses        25603    25603           
  Partials       1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. labels Apr 11, 2024
@ruanwenjun ruanwenjun self-assigned this Apr 11, 2024
@ruanwenjun ruanwenjun merged commit 883848f into apache:dev Apr 11, 2024
60 of 61 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeCaffeine branch April 11, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants