Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Api] Delete useless batchUpdateUdfFunc method #15844

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[Improvement][Api] Delete useless batchUpdateUdfFunc method #15844

merged 1 commit into from
Apr 15, 2024

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Apr 15, 2024

@qingwli qingwli self-assigned this Apr 15, 2024
@qingwli qingwli added the improvement make more easy to user or prompt friendly label Apr 15, 2024
@qingwli qingwli added this to the 3.2.2 milestone Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.18%. Comparing base (08ac132) to head (4843af8).

❗ Current head 4843af8 differs from pull request most recent head 934a142. Consider uploading reports for the commit 934a142 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15844      +/-   ##
============================================
- Coverage     39.25%   39.18%   -0.07%     
+ Complexity     4912     4891      -21     
============================================
  Files          1323     1323              
  Lines         45191    45191              
  Branches       4812     4812              
============================================
- Hits          17738    17707      -31     
- Misses        25570    25601      +31     
  Partials       1883     1883

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

caishunfeng
caishunfeng approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@caishunfeng caishunfeng merged commit efbffac into apache:dev Apr 15, 2024
60 checks passed
@qingwli qingwli deleted the delet-useless-code branch April 15, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@qingwli qingwli

Labels
backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

[Improvement][Api] Delete useless batchUpdateUdfFunc method
3 participants
@qingwli @codecov-commenter @caishunfeng