Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Audit] Change time to create_time #15846

Merged
merged 7 commits into from
Apr 15, 2024
Merged

[Improvement][Audit] Change time to create_time #15846

merged 7 commits into from
Apr 15, 2024

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Apr 15, 2024

@github-actions github-actions bot added UI ui and front end related backend labels Apr 15, 2024
@SbloodyS SbloodyS added the 3.3.0 label Apr 15, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Apr 15, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.59%. Comparing base (6844c65) to head (36204c7).

❗ Current head 36204c7 differs from pull request most recent head ba69548. Consider uploading reports for the commit ba69548 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15846      +/-   ##
============================================
+ Coverage     39.52%   39.59%   +0.06%     
- Complexity     4996     5017      +21     
============================================
  Files          1347     1347              
  Lines         45646    45646              
  Branches       4892     4892              
============================================
+ Hits          18042    18073      +31     
+ Misses        25680    25649      -31     
  Partials       1924     1924

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanwenjun
ruanwenjun approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@qingwli qingwli merged commit f99d3f1 into apache:dev Apr 15, 2024
60 of 67 checks passed
@qingwli qingwli deleted the audit-log-time-change branch April 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104 Amy0104 is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@qingwli qingwli

Labels
3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Audit] Change time to create_time
4 participants
@qingwli @codecov-commenter @ruanwenjun @SbloodyS