Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix QUARTZ table order is not correct in initialization schema #15857

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 16, 2024

Purpose of the pull request

In some cases, the FOREIGN_KEY_CHECKS might not work(e.g. in Oceanbase ), so it's better not to rely on this setting.

Brief change log

Change the table order in MySQL initialize schema.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun
Copy link
Member Author

⚠️ This PR do not change database DDL synchronize.

Only change the schema order, doesn't change the schema info.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_forbiddenForsuccessUnFinished branch from cf49b24 to 41ba0b1 Compare April 16, 2024 08:40
Copy link

mergeable bot commented Apr 16, 2024

⚠️ This PR do not change database DDL synchronize.

@caishunfeng caishunfeng added bug Something isn't working 3.2.2 labels Apr 16, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng changed the title Fix QUARTZ table order is not correct in initialization schema [Bug] Fix QUARTZ table order is not correct in initialization schema Apr 16, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 16, 2024
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit ead5453 into apache:dev Apr 16, 2024
60 of 67 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_forbiddenForsuccessUnFinished branch April 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants