Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ssh heartbeat type to IGNORE #15858

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 16, 2024

Purpose of the pull request

related issue

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Apr 16, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 16, 2024
@ruanwenjun ruanwenjun added the bug Something isn't working label Apr 16, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.2.2 label Apr 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.56%. Comparing base (ead5453) to head (c8fcfbb).

❗ Current head c8fcfbb differs from pull request most recent head 4386a44. Consider uploading reports for the commit 4386a44 to get more accurate results

Files Patch % Lines
...lphinscheduler/plugin/datasource/ssh/SSHUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15858      +/-   ##
============================================
+ Coverage     39.49%   39.56%   +0.07%     
- Complexity     4989     5014      +25     
============================================
  Files          1347     1347              
  Lines         45629    45629              
  Branches       4890     4889       -1     
============================================
+ Hits          18023    18055      +32     
+ Misses        25682    25648      -34     
- Partials       1924     1926       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun merged commit 9437d27 into apache:dev Apr 16, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants