Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Helm] fix image.registry #15860

Merged
merged 3 commits into from
Apr 19, 2024
Merged

[Bug][Helm] fix image.registry #15860

merged 3 commits into from
Apr 19, 2024

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Gallardot Gallardot changed the title Fix helm doc [Bug][Helm] fix image.registry Apr 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.59%. Comparing base (d306f1d) to head (e32ad7e).

❗ Current head e32ad7e differs from pull request most recent head c75b81c. Consider uploading reports for the commit c75b81c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15860      +/-   ##
============================================
+ Coverage     39.52%   39.59%   +0.06%     
- Complexity     5002     5019      +17     
============================================
  Files          1348     1348              
  Lines         45674    45674              
  Branches       4896     4897       +1     
============================================
+ Hits          18053    18084      +31     
+ Misses        25698    25667      -31     
  Partials       1923     1923              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rickchengx rickchengx added the bug Something isn't working label Apr 18, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Signed-off-by: Gallardot <gallardot@apache.org>
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rickchengx rickchengx merged commit a9decc9 into apache:dev Apr 19, 2024
62 checks passed
@Gallardot Gallardot deleted the fix-helm-doc branch April 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [K8S] Deploying version 3.2.1 with Helm, unable to pull the image.
6 participants