Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write audit log error will cause the request failed #15868

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable mergeable bot removed the backend label Apr 17, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixAuditLogErrorCauseRequestFailed branch from 3f59d0d to 9e9e243 Compare April 18, 2024 01:53
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 39.37%. Comparing base (9437d27) to head (06f3b17).
Report is 1 commits behind head on dev.

❗ Current head 06f3b17 differs from pull request most recent head 9e9e243. Consider uploading reports for the commit 9e9e243 to get more accurate results

Files Patch % Lines
...cheduler/api/audit/operator/BaseAuditOperator.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15868      +/-   ##
============================================
- Coverage     39.57%   39.37%   -0.20%     
+ Complexity     5010     4968      -42     
============================================
  Files          1347     1347              
  Lines         45629    45628       -1     
  Branches       4890     4890              
============================================
- Hits          18057    17968      -89     
- Misses        25648    25745      +97     
+ Partials       1924     1915       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixAuditLogErrorCauseRequestFailed branch from 9e9e243 to 8f82d81 Compare April 18, 2024 02:54
@ruanwenjun ruanwenjun added ready-to-merge bug Something isn't working labels Apr 18, 2024
Copy link

sonarcloud bot commented Apr 18, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun self-assigned this Apr 18, 2024
@ruanwenjun ruanwenjun merged commit a8bc237 into apache:dev Apr 18, 2024
59 of 60 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixAuditLogErrorCauseRequestFailed branch April 18, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants