[TEST] inc coverage of logger service #15870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
reviewed
Apr 18, 2024
...inscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/LoggerServiceTest.java
Outdated
Show resolved
Hide resolved
abzymeinsjtu
changed the title
abzymeinsjtu
force-pushed
the
feat_inc_coverage_of_logger_service
branch
from
5bb88c0
to
728e274
Compare
abzymeinsjtu
force-pushed
the
feat_inc_coverage_of_logger_service
branch
from
728e274
to
7ad4f37
Compare
abzymeinsjtu
force-pushed
the
feat_inc_coverage_of_logger_service
branch
from
7ad4f37
to
9a04802
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15870 +/- ##
============================================
+ Coverage 39.28% 39.38% +0.10%
- Complexity 4951 4975 +24
============================================
Files 1348 1348
Lines 45660 45659 -1
Branches 4894 4895 +1
============================================
+ Hits 17937 17983 +46
+ Misses 25808 25764 -44
+ Partials 1915 1912 -3 ☔ View full report in Codecov by Sentry. |
|
EricGao888
approved these changes
Apr 18, 2024
EricGao888
added
ready-to-merge
test
improvement
rickchengx
reviewed
Apr 18, 2024
| return user; | ||
| } | ||
|
|
||
| public static User getAdminUser() { |
There was a problem hiding this comment.
It seems that this part is not used in this PR
Others LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
increase coverage of logger service