Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-28] Donnot scan whole project beans under classpath #15874

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 18, 2024

Purpose of the pull request

close #15877

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun marked this pull request as draft April 18, 2024 13:52
@mergeable mergeable bot removed the backend label Apr 18, 2024
@ruanwenjun ruanwenjun changed the title Donnot scan whole bean under classpath Donnot scan whole project beans under classpath Apr 18, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_donScanWholeProject branch from d8eb823 to 108fd39 Compare April 18, 2024 15:08
@ruanwenjun ruanwenjun changed the title Donnot scan whole project beans under classpath [DSIP-28] Donnot scan whole project beans under classpath Apr 18, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_donScanWholeProject branch from 108fd39 to 85b09fd Compare April 18, 2024 15:43
@ruanwenjun ruanwenjun self-assigned this Apr 18, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 18, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_donScanWholeProject branch 10 times, most recently from 3758120 to 9cd3f14 Compare April 19, 2024 07:55
@ruanwenjun ruanwenjun marked this pull request as ready for review April 19, 2024 07:55
Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Wait for CI

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 16.21622% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 39.60%. Comparing base (d306f1d) to head (ac48c21).

❗ Current head ac48c21 differs from pull request most recent head 9cd3f14. Consider uploading reports for the commit 9cd3f14 to get more accurate results

Files Patch % Lines
...inscheduler/plugin/task/api/TaskPluginManager.java 0.00% 6 Missing ⚠️
...n/registry/etcd/EtcdRegistryAutoConfiguration.java 0.00% 5 Missing ⚠️
.../zookeeper/ZookeeperRegistryAutoConfiguration.java 0.00% 5 Missing ⚠️
...er/api/service/impl/TaskDefinitionServiceImpl.java 40.00% 1 Missing and 2 partials ⚠️
...api/service/impl/ProcessDefinitionServiceImpl.java 0.00% 2 Missing ⚠️
...ver/master/runner/TaskExecutionContextFactory.java 0.00% 2 Missing ⚠️
...lphinscheduler/api/dto/task/TaskUpdateRequest.java 0.00% 1 Missing ⚠️
...r/api/service/impl/ProcessInstanceServiceImpl.java 0.00% 0 Missing and 1 partial ⚠️
...e/dolphinscheduler/common/CommonConfiguration.java 0.00% 1 Missing ⚠️
...e/dolphinscheduler/server/master/MasterServer.java 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15874      +/-   ##
============================================
+ Coverage     39.52%   39.60%   +0.07%     
- Complexity     5002     5015      +13     
============================================
  Files          1348     1349       +1     
  Lines         45674    45578      -96     
  Branches       4896     4886      -10     
============================================
- Hits          18053    18051       -2     
+ Misses        25698    25609      -89     
+ Partials       1923     1918       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, This avoids loading unnecessary beans

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_donScanWholeProject branch from 9cd3f14 to d8aeb9f Compare April 19, 2024 08:52
@qingwli qingwli added the improvement make more easy to user or prompt friendly label Apr 19, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit 285c5a8 into apache:dev Apr 19, 2024
61 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_donScanWholeProject branch April 19, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend DSIP improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-28] Donot scan whole project beans under classpath
4 participants