Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix failure to recover stopped instance #15880

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Conversation

privking
Copy link
Contributor

Purpose of the pull request

Fix failure to recover stopped instance
error

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

ruanwenjun
ruanwenjun previously approved these changes Apr 19, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added the bug Something isn't working label Apr 19, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 19, 2024
rickchengx
rickchengx previously approved these changes Apr 19, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx
Copy link
Contributor

@privking please run 'mvn spotless:apply' to fix the code style

@privking privking dismissed stale reviews from rickchengx and ruanwenjun via e67bf80 April 19, 2024 11:40
@privking
Copy link
Contributor Author

fixed

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.53%. Comparing base (285c5a8) to head (15ebdcd).

❗ Current head 15ebdcd differs from pull request most recent head ade8ae6. Consider uploading reports for the commit ade8ae6 to get more accurate results

Files Patch % Lines
...instance/pause/recover/RecoverExecuteFunction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15880      +/-   ##
============================================
- Coverage     39.60%   39.53%   -0.07%     
+ Complexity     5015     4994      -21     
============================================
  Files          1349     1349              
  Lines         45578    45578              
  Branches       4886     4886              
============================================
- Hits          18051    18020      -31     
- Misses        25609    25640      +31     
  Partials       1918     1918              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 19, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your patch.

@ruanwenjun ruanwenjun merged commit e66441a into apache:dev Apr 19, 2024
61 of 62 checks passed
@privking privking deleted the fixbug branch April 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants