Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor record audit log logic #15881

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Apr 19, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@qingwli qingwli added the improvement make more easy to user or prompt friendly label Apr 19, 2024
@qingwli qingwli added this to the 3.2.2 milestone Apr 19, 2024
@qingwli qingwli self-assigned this Apr 19, 2024
@mergeable mergeable bot removed the backend label Apr 19, 2024
@qingwli qingwli modified the milestones: 3.2.2, 3.3.0 Apr 19, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear the AuditLocalContent after return/throwing

qingwli and others added 3 commits April 19, 2024 13:45
…/api/audit/OperatorLogAspect.java

Co-authored-by: Wenjun Ruan <wenjun@apache.org>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 39.52%. Comparing base (32f9288) to head (0e3d82e).

❗ Current head 0e3d82e differs from pull request most recent head a425633. Consider uploading reports for the commit a425633 to get more accurate results

Files Patch % Lines
.../dolphinscheduler/api/audit/OperatorLogAspect.java 65.21% 6 Missing and 2 partials ⚠️
...ache/dolphinscheduler/api/audit/OperatorUtils.java 75.00% 1 Missing ⚠️
...cheduler/api/audit/operator/BaseAuditOperator.java 90.90% 0 Missing and 1 partial ⚠️
...er/api/service/impl/TaskDefinitionServiceImpl.java 50.00% 1 Missing ⚠️
.../dolphinscheduler/common/enums/AuditModelType.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15881      +/-   ##
============================================
+ Coverage     39.38%   39.52%   +0.13%     
- Complexity     4975     4998      +23     
============================================
  Files          1348     1348              
  Lines         45659    45674      +15     
  Branches       4895     4897       +2     
============================================
+ Hits          17984    18053      +69     
+ Misses        25763    25698      -65     
- Partials       1912     1923      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 19, 2024

@ruanwenjun ruanwenjun merged commit d306f1d into apache:dev Apr 19, 2024
62 checks passed
@qingwli qingwli deleted the audit-log-update branch April 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants