Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-32][Master] Add command fetcher strategy for master fetch command #15900

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 24, 2024

Purpose of the pull request

close ##15897

Brief change log

  • Change the master loop command strategy, and support fetch discontinuous orders commands .

Verify this pull request

Test by UT and E2E

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 39.72%. Comparing base (5a6c6c3) to head (7223d46).

❗ Current head 7223d46 differs from pull request most recent head b572a11. Consider uploading reports for the commit b572a11 to get more accurate results

Files Patch % Lines
...rver/master/command/IdSlotBasedCommandFetcher.java 0.00% 21 Missing ⚠️
...er/master/command/CommandFetcherConfiguration.java 0.00% 9 Missing ⚠️
...ler/server/master/config/CommandFetchStrategy.java 55.55% 2 Missing and 2 partials ⚠️
...server/master/runner/MasterSchedulerBootstrap.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15900   +/-   ##
=========================================
  Coverage     39.72%   39.72%           
- Complexity     5034     5037    +3     
=========================================
  Files          1349     1353    +4     
  Lines         45615    45637   +22     
  Branches       4891     4892    +1     
=========================================
+ Hits          18122    18131    +9     
- Misses        25578    25591   +13     
  Partials       1915     1915           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addCommandFetchStrategy branch 2 times, most recently from 0e33af2 to ca44ca5 Compare April 25, 2024 02:02
@SbloodyS SbloodyS added the 3.2.2 label Apr 25, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addCommandFetchStrategy branch 2 times, most recently from c7b771c to 2e3170c Compare April 25, 2024 14:43
Radeity
Radeity previously approved these changes Apr 26, 2024
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addCommandFetchStrategy branch 2 times, most recently from b36f0d1 to 4abba0d Compare April 28, 2024 07:47
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addCommandFetchStrategy branch 2 times, most recently from 91acdab to aeb3308 Compare April 28, 2024 08:19
@ruanwenjun ruanwenjun requested a review from Radeity April 28, 2024 09:23
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addCommandFetchStrategy branch from aeb3308 to b572a11 Compare April 29, 2024 02:04
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng
Copy link
Contributor

Purpose of the pull request

close ##15897

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Please improve the pr description.

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 647cbae into apache:dev Apr 29, 2024
61 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addCommandFetchStrategy branch April 29, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants