Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] increase coverage of project parameter service test #15905

Conversation

abzymeinsjtu
Copy link
Contributor

Purpose of the pull request

increase coverage of project parameter service test

@rickchengx rickchengx added test improvement make more easy to user or prompt friendly 3.2.2 3.3.0 and removed 3.2.2 labels Apr 24, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.68%. Comparing base (59f060e) to head (a8f72d4).

❗ Current head a8f72d4 differs from pull request most recent head de9a42d. Consider uploading reports for the commit de9a42d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15905      +/-   ##
============================================
+ Coverage     39.63%   39.68%   +0.05%     
+ Complexity     5019     5012       -7     
============================================
  Files          1349     1349              
  Lines         45583    45580       -3     
  Branches       4890     4890              
============================================
+ Hits          18065    18090      +25     
+ Misses        25596    25574      -22     
+ Partials       1922     1916       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@EricGao888 EricGao888 merged commit 1d13ef0 into apache:dev Apr 24, 2024
62 checks passed
@abzymeinsjtu abzymeinsjtu deleted the feat_inc_coverage_of_project_related_service branch April 25, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants