Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-34] Change required_approving_review_count to 2 #15914

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 25, 2024

Purpose of the pull request

close #15913

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot removed the CI&CD label Apr 25, 2024
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly CI&CD labels Apr 25, 2024
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍SGTM!

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun self-assigned this Apr 25, 2024
Copy link

sonarcloud bot commented Apr 25, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun merged commit d1135ea into apache:dev Apr 25, 2024
61 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_changeApCountTo2 branch April 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI&CD improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-34] Change required_approving_review_count to 2
3 participants