Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] remove AppVersion from common labels #16066

Merged
merged 1 commit into from
May 25, 2024

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

This is to fix incompatibilities that occurred after the helm charts version upgrade

ref: #16042 (comment)

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.66%. Comparing base (26f2aad) to head (63968df).

Current head 63968df differs from pull request most recent head d396be1

Please upload reports for the commit d396be1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16066   +/-   ##
=========================================
  Coverage     40.66%   40.66%           
+ Complexity     5228     5224    -4     
=========================================
  Files          1380     1380           
  Lines         46009    46009           
  Branches       4918     4919    +1     
=========================================
  Hits          18708    18708           
  Misses        25376    25376           
  Partials       1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@wangxj3 wangxj3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit fb9172c into apache:dev May 25, 2024
125 of 126 checks passed
wangxj3 pushed a commit to wangxj3/dolphinscheduler that referenced this pull request May 25, 2024
@Gallardot Gallardot deleted the appversion branch May 27, 2024 01:15
@SbloodyS SbloodyS added bug Something isn't working backend 3.2.2 labels Jun 26, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Jun 26, 2024
SbloodyS pushed a commit to SbloodyS/dolphinscheduler that referenced this pull request Jun 26, 2024
SbloodyS added a commit that referenced this pull request Jun 26, 2024
* [Fix-16174] Incorrect cluster installation guide. (#16208)

* [Fix][CI] fix the ci error of Values.datasource.profile (#16031)

* [Improvement][Helm] Make configmap of api/master/worker/alert configuration (#16058)

Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml

* Update deploy/kubernetes/dolphinscheduler/values.yaml

* [helm] remove appversion from labels (#16066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants