[DSIP-46] Unify the logic task params data structure between front-end and back-end #16193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
2 times, most recently
from
c227768
to
e261d05
Compare
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
2 times, most recently
from
b969cdc
to
7d7d5f6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...src/main/java/org/apache/dolphinscheduler/plugin/task/api/task/AbstractLogicTaskChannel.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
from
7d7d5f6
to
2fdfb02
Compare
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
5 times, most recently
from
97c8628
to
0639aa9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16193 +/- ##
============================================
+ Coverage 41.00% 41.31% +0.31%
- Complexity 5157 5162 +5
============================================
Files 1400 1403 +3
Lines 44860 44423 -437
Branches 4747 4721 -26
============================================
- Hits 18396 18355 -41
+ Misses 24658 24264 -394
+ Partials 1806 1804 -2 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
8 times, most recently
from
adc2958
to
2d2ae78
Compare
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
from
2d2ae78
to
ba64ebf
Compare
SbloodyS
reviewed
Jun 24, 2024
...eduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_unifyLogicTaskParams
branch
from
ba64ebf
to
1b0173e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16153
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md