Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Use testcontainer origin exposed port rather than generate random port #16195

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes Jun 21, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SbloodyS
SbloodyS previously approved these changes Jun 21, 2024
rickchengx
rickchengx previously approved these changes Jun 21, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun dismissed stale reviews from rickchengx and SbloodyS via 524fae7 June 21, 2024 08:18
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useOriginPort branch 6 times, most recently from e9bd1b2 to 4d5b958 Compare June 21, 2024 10:56
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

sonarcloud bot commented Jun 21, 2024

@ruanwenjun ruanwenjun merged commit f0e0395 into apache:dev Jun 21, 2024
64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_useOriginPort branch June 21, 2024 14:19
@SbloodyS SbloodyS added the 3.3.0 label Jun 26, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants