-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16224] Add Shell using file E2E case #16220
Conversation
7e8461b
to
a055bcf
Compare
...uler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/security/SecurityPage.java
Show resolved
Hide resolved
...rc/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/WorkflowInstanceTab.java
Outdated
Show resolved
Hide resolved
...se/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/TaskInstanceTab.java
Outdated
Show resolved
Hide resolved
...se/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/TaskInstanceTab.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16220 +/- ##
============================================
- Coverage 41.25% 41.24% -0.01%
Complexity 5121 5121
============================================
Files 1397 1397
Lines 44054 44055 +1
Branches 4666 4666
============================================
- Hits 18173 18171 -2
- Misses 24101 24104 +3
Partials 1780 1780 ☔ View full report in Codecov by Sentry. |
a055bcf
to
90b41f7
Compare
ba985ba
to
f035474
Compare
...eduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/security/TenantPage.java
Outdated
Show resolved
Hide resolved
...eduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/security/TenantPage.java
Outdated
Show resolved
Hide resolved
...ler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/tasks/ShellTaskE2ETest.java
Show resolved
Hide resolved
...ler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/tasks/ShellTaskE2ETest.java
Show resolved
Hide resolved
f035474
to
1731f82
Compare
1731f82
to
0ec73a5
Compare
e552cc4
to
c55b25e
Compare
c55b25e
to
793bd32
Compare
793bd32
to
d85f809
Compare
...ler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/tasks/ShellTaskE2ETest.java
Show resolved
Hide resolved
6880d83
to
98bf1d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Purpose of the pull request
close #16224
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md