Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16224] Add Shell using file E2E case #16220

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 26, 2024

Purpose of the pull request

close #16224

Brief change log

  • Add ShellE2ECase
  • Change the default await interval, this can help to speed up the e2e case.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (02bef74) to head (864b2e4).

Current head 864b2e4 differs from pull request most recent head a737b85

Please upload reports for the commit a737b85 to get more accurate results.

Files Patch % Lines
...nscheduler/api/controller/ResourcesController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16220      +/-   ##
============================================
- Coverage     41.25%   41.24%   -0.01%     
  Complexity     5121     5121              
============================================
  Files          1397     1397              
  Lines         44054    44055       +1     
  Branches       4666     4666              
============================================
- Hits          18173    18171       -2     
- Misses        24101    24104       +3     
  Partials       1780     1780              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the UI ui and front end related label Jun 26, 2024
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Jun 26, 2024
@ruanwenjun ruanwenjun changed the title Add Shell E2E case [Fix-16224] Add Shell using file E2E case Jun 27, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@caishunfeng caishunfeng merged commit 46eff34 into apache:dev Jun 27, 2024
63 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addE2ECase branch June 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Task cannot select resource files since listing is 404
4 participants