[Improvement] Add skywalking agent plugin

[hailin0]

Tips

• Thanks very much for contributing to Apache DolphinScheduler.
• Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request

• Add skywalking agent plugin

Brief change log

• Add ext/skywalking module to root pom.xml
• Update dolphinscheduler-dist pom.xml and src/main/assembly/dolphinscheduler-binary.xml
• dolphinscheduler-docs

Verify this pull request

[hailin0]

build package

import dashboard

dashboard

ds job

tracing

log

jvm & cpu

API & Endpoint

[lgcareer]

Hi,If this pr will generate more jars than before,there need add license files under dolphinscheduler-dist/releases.

[hailin0]

Hi,If this pr will generate more jars than before,there need add license files under dolphinscheduler-dist/releases.

Please check.

[wu-sheng]

I have a question for the DolphinScheduler PMC, why you are requiring all Apache 2.0 licenses in your dist folder? SkyWalking and DolphinScheduler are in the same foundation, we are using the same License. Basically, you just need to mention Apache SkyWalking is included in your distribution, but I can't find your dist LICENSE change, where is it?
Then about the dependencies of SkyWalking's agent, there are byte-buddy, grpc, protobuf(and several others) included in the SkyWalking binary, so checking through the jar files is not accurate in every case, such as this one.

[wu-sheng]

https://github.com/apache/incubator-dolphinscheduler/blob/1.3.6-prepare/dolphinscheduler-dist/release-docs/LICENSE This license file should be updated by adding SkyWalking and its dependencies(agent core's) to it. But I highly doubt, it is meaningful to add all the duplicated Apache 2.0 licenses.

[lgcareer]

I have a question for the DolphinScheduler PMC, why you are requiring all Apache 2.0 licenses in your dist folder? SkyWalking and DolphinScheduler are in the same foundation, we are using the same License. Basically, you just need to mention Apache SkyWalking is included in your distribution, but I can't find your dist LICENSE change, where is it?
Then about the dependencies of SkyWalking's agent, there are byte-buddy, grpc, protobuf(and several others) included in the SkyWalking binary, so checking through the jar files is not accurate in every case, such as this one.

Thanks for tips and help,If the license of new dependencies are standard apache 2.0 license,It's not necceary to add the new license file under the folder dolphinscheduler-dist/release-docs,but it need to be added under dolphinscheduler-dist/release-docs/LICENSE.

[wu-sheng]

@hailin0 I think you still miss to update https://github.com/apache/incubator-dolphinscheduler/blob/1.3.6-prepare/dolphinscheduler-dist/release-docs/LICENSE

[wu-sheng]

One question, where could I read your documentation? I could help on checking whether it is accurate from the SkyWalking's perspective.

[hailin0]

One question, where could I read your documentation? I could help on checking whether it is accurate from the SkyWalking's perspective.

it's here apache/dolphinscheduler-website#299

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
16.2% Duplication

[wu-sheng]

Good to me. Thanks @hailin0

[lgcareer]

+1