[fix-8929][DAO]Description Failed to upload the file because the full name was too long #9020

Hou-Shuaishuai · 2022-03-19T12:31:22Z

No description provided.

… name was too long

SbloodyS · 2022-03-22T06:43:00Z

dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql

@@ -757,7 +757,7 @@ CREATE TABLE `t_ds_resources` (
  `create_time` datetime DEFAULT NULL COMMENT 'create time',
  `update_time` datetime DEFAULT NULL COMMENT 'update time',
  `pid` int(11) DEFAULT NULL,
-  `full_name` varchar(64) DEFAULT NULL,
+  `full_name` varchar(128) DEFAULT NULL,


Please also add it to postgres and upgrade sql.

Has been updated

You need to create a folder 2.0.6_schema like dolphinscheduler-dao/src/main/resources/sql/upgrade/2.0.4_schema. And put ALTER TABLE t_ds_resources MODIFY COLUMN NAME VARCHAR(128); in mysq/dolphinscheduler_ddl.sql. Same as postgresql.

It has been modified, please review it again

…e full name was too long

SbloodyS · 2022-03-24T03:21:15Z

...cheduler-dao/src/main/resources/sql/upgrade/2.0.6_schema/postgresql/dolphinscheduler_ddl.sql

+*/
+
+-- uc_dolphin_T_t_ds_resources_R_full_name
+delimiter d//


Please keep the same style as

dolphinscheduler/dolphinscheduler-dao/src/main/resources/sql/upgrade/2.0.2_schema/postgresql/dolphinscheduler_ddl.sql

Lines 17 to 41 in b9448c3

delimiter d//

CREATE OR REPLACE FUNCTION public.dolphin_update_metadata(

)

RETURNS character varying

LANGUAGE 'plpgsql'

COST 100

VOLATILE PARALLEL UNSAFE

AS $BODY$

DECLARE

v_schema varchar;

BEGIN

---get schema name

v_schema =current_schema();

EXECUTE 'ALTER TABLE ' || quote_ident(v_schema) ||'.t_ds_process_instance ADD COLUMN IF NOT EXISTS "restart_time" timestamp DEFAULT NULL';

return 'Success!';

exception when others then

---Raise EXCEPTION '(%)',SQLERRM;

return SQLERRM;

END;

$BODY$;

select dolphin_update_metadata();

d//

For continuous maintenance by others.

please review it again

codecov-commenter · 2022-03-24T03:25:02Z

Codecov Report

Merging #9020 (df7ee1b) into dev (926fad8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9020      +/-   ##
============================================
- Coverage     40.28%   40.27%   -0.01%     
+ Complexity     4366     4365       -1     
============================================
  Files           808      808              
  Lines         32569    32569              
  Branches       3650     3650              
============================================
- Hits          13119    13118       -1     
  Misses        18220    18220              
- Partials       1230     1231       +1

Impacted Files	Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java	`77.77% <0.00%> (-5.56%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926fad8...df7ee1b. Read the comment docs.

…e full name was too long

SbloodyS

LGTM, thanks.

Please take a look at it. @zhongjiajie @caishunfeng

caishunfeng · 2022-03-24T07:25:22Z

I had approve to run CI test.

SbloodyS · 2022-03-25T02:43:41Z

@Hou-Shuaishuai Hi, It seems there are some errors in ci. Can you merge the latest dev branch to this pr? And we will rerun it.

Hou-Shuaishuai · 2022-03-25T03:28:30Z

@SbloodyS Have submitted

sonarcloud · 2022-03-25T03:52:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

caishunfeng

LGTM

caishunfeng · 2022-03-25T05:40:14Z

_ No description provided. _

Hi @Hou-Shuaishuai Thanks for your contribution, and next time please add some detail description of this pr.
BTW, this pr close #8929

… name was too long (apache#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-apache#8929][fix]Description Failed to upload the file because the full name was too long * [DS-apache#8929][fix]Description Failed to upload the file because the full name was too long * [DS-apache#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn>

* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>

* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 * fix ut * fix pick error Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>

* issue 8645 (#8811) Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> * [fix-8929][DAO]Description Failed to upload the file because the full name was too long (#9020) * [fix-8929][DAO]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long * [DS-#8929][fix]Description Failed to upload the file because the full name was too long Co-authored-by: houshuai <houshuai@jiguang.cn> * [BUG][ALERT-SERVER]validate script before alert script (#9834) * validate script before alert script * fix validate script before alert script * pick 8811/9020/9834 * fix ut * fix pick error * fix 10762 Co-authored-by: zhanqian <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: zhanqian <zhanqian@cai-inc.com> Co-authored-by: shuai hou <120306274@qq.com> Co-authored-by: houshuai <houshuai@jiguang.cn> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: JinyLeeChina <jiny.li@foxmail.com>

houshuai added 2 commits March 19, 2022 10:56

Merge remote-tracking branch 'upstream/dev' into dev

e83c95a

[fix-8929][DAO]Description Failed to upload the file because the full…

2e239e2

… name was too long

SbloodyS reviewed Mar 22, 2022

View reviewed changes

houshuai added 2 commits March 23, 2022 10:42

Merge remote-tracking branch 'upstream/dev' into dev

6702db6

[DS-apache#8929][fix]Description Failed to upload the file because th…

87040cb

…e full name was too long

Hou-Shuaishuai closed this Mar 23, 2022

Hou-Shuaishuai reopened this Mar 23, 2022

caishunfeng added this to the 2.0.6-release milestone Mar 23, 2022

houshuai added 2 commits March 24, 2022 11:05

Merge remote-tracking branch 'upstream/dev' into dev

70b30fa

[DS-apache#8929][fix]Description Failed to upload the file because th…

b01cccf

…e full name was too long

SbloodyS reviewed Mar 24, 2022

View reviewed changes

houshuai added 2 commits March 24, 2022 14:21

Merge remote-tracking branch 'upstream/dev' into dev

5f3841f

[DS-apache#8929][fix]Description Failed to upload the file because th…

df7ee1b

…e full name was too long

SbloodyS approved these changes Mar 24, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/dev' into dev

705637a

caishunfeng added the first time contributor First-time contributor label Mar 25, 2022

caishunfeng approved these changes Mar 25, 2022

View reviewed changes

caishunfeng merged commit 5bd8ba4 into apache:dev Mar 25, 2022

litiliu mentioned this pull request May 2, 2022

[Fix-9856]Failed to upload the file but get misleading error message #9861

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix-8929][DAO]Description Failed to upload the file because the full name was too long #9020

[fix-8929][DAO]Description Failed to upload the file because the full name was too long #9020

Hou-Shuaishuai commented Mar 19, 2022

SbloodyS Mar 22, 2022

Hou-Shuaishuai Mar 23, 2022

SbloodyS Mar 23, 2022 •

edited

Hou-Shuaishuai Mar 24, 2022

SbloodyS Mar 24, 2022

Hou-Shuaishuai Mar 24, 2022

codecov-commenter commented Mar 24, 2022 •

edited

SbloodyS left a comment

caishunfeng commented Mar 24, 2022

SbloodyS commented Mar 25, 2022

Hou-Shuaishuai commented Mar 25, 2022

sonarcloud bot commented Mar 25, 2022

caishunfeng left a comment

caishunfeng commented Mar 25, 2022

	delimiter d//
	CREATE OR REPLACE FUNCTION public.dolphin_update_metadata(
	)
	RETURNS character varying
	LANGUAGE 'plpgsql'
	COST 100
	VOLATILE PARALLEL UNSAFE
	AS $BODY$
	DECLARE
	v_schema varchar;
	BEGIN
	---get schema name
	v_schema =current_schema();

	EXECUTE 'ALTER TABLE ' \|\| quote_ident(v_schema) \|\|'.t_ds_process_instance ADD COLUMN IF NOT EXISTS "restart_time" timestamp DEFAULT NULL';
	return 'Success!';
	exception when others then
	---Raise EXCEPTION '(%)',SQLERRM;
	return SQLERRM;
	END;
	$BODY$;

	select dolphin_update_metadata();

	d//

[fix-8929][DAO]Description Failed to upload the file because the full name was too long #9020

[fix-8929][DAO]Description Failed to upload the file because the full name was too long #9020

Conversation

Hou-Shuaishuai commented Mar 19, 2022

SbloodyS Mar 22, 2022

Choose a reason for hiding this comment

Hou-Shuaishuai Mar 23, 2022

Choose a reason for hiding this comment

SbloodyS Mar 23, 2022 • edited

Choose a reason for hiding this comment

Hou-Shuaishuai Mar 24, 2022

Choose a reason for hiding this comment

SbloodyS Mar 24, 2022

Choose a reason for hiding this comment

Hou-Shuaishuai Mar 24, 2022

Choose a reason for hiding this comment

codecov-commenter commented Mar 24, 2022 • edited

Codecov Report

SbloodyS left a comment

Choose a reason for hiding this comment

caishunfeng commented Mar 24, 2022

SbloodyS commented Mar 25, 2022

Hou-Shuaishuai commented Mar 25, 2022

sonarcloud bot commented Mar 25, 2022

caishunfeng left a comment

Choose a reason for hiding this comment

caishunfeng commented Mar 25, 2022

SbloodyS Mar 23, 2022 •

edited

codecov-commenter commented Mar 24, 2022 •

edited