Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]Added direct access to BE through the intranet #187

Merged
merged 7 commits into from Sep 5, 2023

Conversation

DongLiang-0
Copy link
Contributor

@DongLiang-0 DongLiang-0 commented Aug 28, 2023

Proposed changes

When the flink connector accesses DORIS, it parses out all surviving BE nodes according to the FE address filled in.

However, when the BE node is deployed, most of the internal network IP is filled in,so the BE node parsed by FE is the internal network IP. When flink is deployed on a non-intranet segment,the BE node will be inaccessible on the network.

In this pr, you can access the BE node on the intranet by directly configuring DorisOptions.builder().setBenodes().build()
, after you configure this parameter, Flink Connector will not parse all BE nodes through FE nodes.

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented Aug 29, 2023

By the way, add the options of flink table, thanks

@JNSimba
Copy link
Member

JNSimba commented Aug 31, 2023

By the way, add the options of flink table, thanks

and please also add options in databasesync , thanks

@DongLiang-0
Copy link
Contributor Author

By the way, add the options of flink table, thanks

and please also add options in databasesync , thanks

Thanks for your suggestion, I have supported.

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 8c15c4f into apache:master Sep 5, 2023
2 checks passed
@JNSimba JNSimba mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants