Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support two phase commit #122

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

gnehil
Copy link
Contributor

@gnehil gnehil commented Jul 27, 2023

Proposed changes

Spark doris connector support two-phase commit.

Set the option doris.sink.enable-2pc to true to enable two-phase commit for stream load.

After enabled, the behavior is as follows:
Pre-submit stream load requests for each batch load, and then

  1. When the job succeeds, all pre-committed transactions will be committed.
  2. When the job fails, all pre-committed transactions will be aborted.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented Jul 27, 2023

good job

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit b1fbc6e into apache:master Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants