Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support fe https request #189

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

gnehil
Copy link
Contributor

@gnehil gnehil commented Feb 5, 2024

Proposed changes

Issue Number: #124

Problem Summary:

  1. Support FE https request.
    You can set the following options to enable https:

    • Set doris.enable.https to true
    • Set doris.https.key-store-path to the file path of a valid ssl certificate
    • Set doris.https.key-store-type to the certificate type, the default value is JKS
    • Set doris.https.key-store-password to certificate file password
      Note:
      • Since BE does not currently support https, stream load through https only supports redirection by FE (setting the doris.sink.auto-redirect option to true, which is the default value)
  2. Refactor RestService

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit a9725bf into apache:master Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants