Skip to content

Commit

Permalink
rebase to master solve conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangstar333 committed May 5, 2022
1 parent cc16ca0 commit 95f64ce
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions be/src/vec/aggregate_functions/aggregate_function_window.h
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,10 @@ static IAggregateFunction* create_function_single_value(const String& name,
}
if (which.is_string_or_fixed_string()) {
return new AggregateFunctionTemplate<
Data<LeadAndLagData<StringRef, result_is_nullable, true, StoreType>>>(argument_types);
Data<LeadAndLagData<StringRef, result_is_nullable, true, StoreType>>>(
argument_types);
}
DCHECK(false) << "with unknowed type, failed in create_aggregate_function_leadlag";
DCHECK(false) << "with unknowed type, failed in create_aggregate_function_" << name;
return nullptr;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -710,13 +710,13 @@ private void standardize(Analyzer analyzer) throws AnalysisException {
resetWindow = true;
}

// Change first_value RANGE windows to ROWS
if ((analyticFnName.getFunction().equalsIgnoreCase(FIRSTVALUE))
// Change first_value RANGE windows to ROWS
if ((analyticFnName.getFunction().equalsIgnoreCase(FIRSTVALUE))
&& window != null
&& window.getType() == AnalyticWindow.Type.RANGE) {
window = new AnalyticWindow(AnalyticWindow.Type.ROWS, window.getLeftBoundary(),
window.getRightBoundary());
}
}
}

/**
Expand Down

0 comments on commit 95f64ce

Please sign in to comment.