[enhance] use correct default value for show config action (#19284)

apache · Sep 1, 2023 · c31cb5f · c31cb5f
1 parent d96bc2d
commit c31cb5f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
@@ -1518,7 +1518,11 @@ std::vector<std::vector<std::string>> get_config_info() {
         _config.push_back(it.first);
 
         _config.push_back(field_it->second.type);
-        _config.push_back(it.second);
+        if (0 == strcmp(field_it->second.type, "bool")) {
+            _config.push_back(it.second == "1" ? "true" : "false");
+        } else {
+            _config.push_back(it.second);
+        }
         _config.push_back(field_it->second.valmutable ? "true" : "false");
 
         configs.push_back(_config);

diff --git a/regression-test/suites/compaction/test_compaction_cumu_delete.groovy b/regression-test/suites/compaction/test_compaction_cumu_delete.groovy
@@ -50,13 +50,23 @@ suite("test_compaction_cumu_delete") {
         assert configList instanceof List
 
         boolean disableAutoCompaction = true
+        boolean allowDeleteWhenCumu = false
         for (Object ele in (List) configList) {
             assert ele instanceof List<String>
             if (((List<String>) ele)[0] == "disable_auto_compaction") {
                 disableAutoCompaction = Boolean.parseBoolean(((List<String>) ele)[2])
             }
+            if (((List<String>) ele)[0] == "enable_delete_when_cumu_compaction") {
+                allowDeleteWhenCumu = Boolean.parseBoolean(((List<String>) ele)[2])
+            }
+        }
+
+        if (!allowDeleteWhenCumu) {
+            logger.info("Skip test compaction when cumu compaction because not enabled this config")
+            return
         }
 
+
         def triggerCompaction = { be_host, be_http_port, compact_type ->
             // trigger compactions for all tablets in ${tableName}
             String tablet_id = tablet[0]