Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](cache) Add FileCache for RemoteFile #11186

Merged
merged 13 commits into from Aug 4, 2022

Conversation

pengxiangyu
Copy link
Contributor

Proposed changes

Issue Number: close #11185

Problem Summary:

Add FileCache for RemoteFile, it will be opened in StoragePolicy.
Cold data in remote file will be download to local cache files.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jackwener
Copy link
Member

Please add header of title according to the Requirement

https://doris.apache.org/zh-CN/community/how-to-contribute/commit-format-specification

issue: 11185
Add FileCache for RemoteFile, it will be opened in StoragePolicy.
Cold data in remote file will be download to local cache files.
issue: 11185
Add FileCache for RemoteFile, it will be opened in StoragePolicy.
Cold data in remote file will be download to local cache files.
@pengxiangyu pengxiangyu changed the title Add FileCache for RemoteFile [feature](cache) Add FileCache for RemoteFile Aug 1, 2022
CONF_mInt64(cooldown_lag_time_sec, "10800"); // 3h
CONF_mInt64(max_sub_cache_file_size, "1073741824"); // 1GB
CONF_mInt64(file_cache_alive_time_sec, "604800"); // 1 week
CONF_String(file_cache_type, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better add a comment to describe the possible value

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit a943ada into apache:master Aug 4, 2022
@pengxiangyu pengxiangyu deleted the be_cache_manager branch August 8, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/remote-storage reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add FileCache for RemoteFile
4 participants