[fix](agg)disallow group by bitmap or hll data type #11782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/planner
spaces-X
reviewed
Aug 15, 2022
| @@ -160,6 +161,15 @@ public void setPartitionExprs(List<Expr> exprs) { | |||
| partitionExprs = exprs; | |||
| } | |||
|
|
|||
| private static void validateGroupingExprs(List<Expr> groupingExprs) throws AnalysisException { | |||
There was a problem hiding this comment.
I think it is more reasonable to put this checking logic into GroupByClause's analyze phase.
There was a problem hiding this comment.
Thanks for your time. But there is no group by clause in sql like "select distinct bitmap, hll from xxx", the agg node is created by fe to implement the "distinct" operator, so no analyze function is called in that case. Anyway, I update the error message which is consistent with the error "select count(*) from xxx group by bitmap" now.
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Aug 16, 2022
* [fix](agg)disallow group by bitmap or hll data type
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
disallow "select distinct bitmap, hll from xxx", because in some case, the FE will introduce a agg node with group by bitmap or hll exprs to implement the "distinct" operator. But group by bitmap or hll data type are not supported in BE.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...