Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement](spark-load) support parquet and orc file #13438

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

liujinhui1994
Copy link
Contributor

@liujinhui1994 liujinhui1994 commented Oct 18, 2022

Proposed changes

Issue Number: close #13099

Problem summary

  1. Add support for parquet/orc in SparkDpp.java
  2. Fixed sparkDpp checkstyle issue

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

hi @liujinhui1994 , is this pr being tested?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 60d5e4d into apache:master Oct 20, 2022
ChPi pushed a commit to ChPi/incubator-doris that referenced this pull request Oct 20, 2022
Add support for parquet/orc in SparkDpp.java
Fixed sparkDpp checkstyle issue
@liujinhui1994
Copy link
Contributor Author

hi @liujinhui1994 , is this pr being tested?

The test has been passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/merged-1.1.4 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants